Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example does not build #2

Closed
Be-ing opened this issue Jan 22, 2022 · 2 comments
Closed

example does not build #2

Be-ing opened this issue Jan 22, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@Be-ing
Copy link
Contributor

Be-ing commented Jan 22, 2022

audio on ξ‚  main via πŸ¦€ v1.58.0 
❯ cargo build
    Updating crates.io index
    Updating git repository `https://github.com/udoprog/minimp3-rs`
    Updating git submodule `https://github.com/lieff/minimp3.git`
    Updating git repository `https://github.com/udoprog/rubato`
error: no matching package named `audio` found
location searched: https://github.com/udoprog/rubato?branch=next#4ca6e6f9
required by package `rubato v0.9.0 (https://github.com/udoprog/rubato?branch=next#4ca6e6f9)`
    ... which satisfies git dependency `rubato` of package `examples v0.0.0 (/home/be/sw/audio/examples)`

The examples use your fork of rubato which uses relative filesystem paths for audio. While that may work on your machine, it does not work on mine. I recommend to use patch.crates-io in ~/.cargo/config.toml to work on libraries locally so you don't accidentally commit Cargo.toml in the repository with relative paths specific to your machine.

I see you have made some contributions to rubato but the branch used by the example uses a pretty big change that is not upstream nor do I see a PR for it upstream. Were you intending to make a PR for that upstream?

@udoprog
Copy link
Owner

udoprog commented Jan 26, 2022

Yeah. This is just for experimentation. I don't intend to submit anything upstream until this crate is done. I elaborated more in #3. But, we can certainly make it easier to build the rubato branch by not using relative paths!

@udoprog
Copy link
Owner

udoprog commented Sep 24, 2022

Example should now build, and they've been reconfigured so that they shouldn't break as easily. They now depend on the git version of the crate rather than a published one.

@udoprog udoprog closed this as completed Sep 24, 2022
@udoprog udoprog added the bug Something isn't working label Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants