Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(bug): Translations are only partially loading #297

Open
gregthemitch opened this issue Sep 13, 2024 · 3 comments · May be fixed by #298
Open

(bug): Translations are only partially loading #297

gregthemitch opened this issue Sep 13, 2024 · 3 comments · May be fixed by #298
Assignees
@klinkoberstar @gregthemitch
Labels
bug Something isn't working

Comments

@gregthemitch
Copy link
Collaborator

Describe the bug

Some pages only partially translate their text with the refactored translations.

To Reproduce

Steps to reproduce the behavior:
See the home page as an example. Here the text describing the New Arrivals Resource Portal still has an English translation while the rest of the page is in Spanish. The rest of the page comes in as Spanish.

Expected behavior

All of the text should come in as the correct language.

Additional context

This happens on other pages as well. I'm not sure what the pattern is that causes some of the text to be properly translated, while others aren't.
@gregthemitch gregthemitch added the bug Something isn't working label Sep 13, 2024
@klinkoberstar
Copy link
Contributor

Ah! I think I misunderstood your question when you asked me last week. Yes, it's expected behavior since we haven't formally translated all the text yet. It's set to default to english when no translated text exists.

As long as the HTML code is all written with babel as opposed to the nested JSONs we should be good for now! But I'll look at it more closely before I close the ticket.

@klinkoberstar
Copy link
Contributor

(the "pattern" is I randomly translated some parts on each page to text the functionality) 😂

@klinkoberstar
Copy link
Contributor

@klinkoberstar to look at general.html - make sure that the line breaks aren't causing issues with the translations. Some translations not showing up even when they exist bc of line breaks

@klinkoberstar klinkoberstar linked a pull request Sep 27, 2024 that will close this issue
remove unecessary line breaks #298
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@klinkoberstar klinkoberstar

@gregthemitch gregthemitch

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove unecessary line breaks uchicago-capp-30320/new-arrivals-chi
2 participants
@klinkoberstar @gregthemitch