Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a dark theme toggle and accent colour button in the settings page. #623

Closed
whiskeyPeak opened this issue Dec 7, 2022 · 3 comments · Fixed by #656
Closed

Add a dark theme toggle and accent colour button in the settings page. #623

whiskeyPeak opened this issue Dec 7, 2022 · 3 comments · Fixed by #656
Assignees
Labels
enhancement: UI 👩‍🎨 Enhancement or feature to implement without further design needed

Comments

@whiskeyPeak
Copy link
Contributor

Some distros don't have a system-wide dark mode implementation (eg: linux mint cinnamon) so the software store ends up in light mode with no way to modify it.

We should add an appearance section in the settings page where those 2 options are customizable. I was thinking it looking somewhat similar to the ubuntu flutter settings app?

Screenshot from 2022-12-07 00-16-29

@Feichtmeier Can you assign this to me if it's a feature we want to implement? Thank you :D

@whiskeyPeak whiskeyPeak changed the title Add a dark them toggle and accent colour button in the settings page. Add a dark theme toggle and accent colour button in the settings page. Dec 7, 2022
@Feichtmeier
Copy link
Member

@whiskeyPeak ok. But there needs to be an option that says follow system theme

@Feichtmeier Feichtmeier added the enhancement: UI 👩‍🎨 Enhancement or feature to implement without further design needed label Dec 7, 2022
@madsrh
Copy link
Member

madsrh commented Dec 7, 2022

So every app will have their own dark mode settings? 🤔

@Feichtmeier
Copy link
Member

Feichtmeier commented Dec 7, 2022

So every app will have their own dark mode settings? 🤔

no, but either opt-in to system dark or light

what is common sense on android and some gtk apps is:

  • use what the system uses
  • dark
  • light

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement: UI 👩‍🎨 Enhancement or feature to implement without further design needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants