PROPOSAL: Add Codacy to check code quality

[noelmiller]

Since we are considering splitting out our container files into smaller bash scripts (rather than doing inline bash), I think it would be helpful to have a code analysis tool to help with consistency and code quality: https://www.codacy.com/pricing

The open source plan is free and it can be added as a check in Github on a repo.

See JasonN3/build-container-installer#100 as an example.

[castrojo]

+1, I was thinking a shellcheck action but this should be fine to test. I can add it at an org level but would prefer to test it in one repo that isn't main first to get a feel for it.

I don't mind just turning it on as a nonblocking check in bluefin for a while, lmk.

[noelmiller]

+1, I was thinking a shellcheck action but this should be fine to test. I can add it at an org level but would prefer to test it in one repo that isn't main first to get a feel for it.

I don't mind just turning it on as a nonblocking check in bluefin for a while, lmk.

For sure! I think this would be valuable in all repos. We most certainly don't need to turn it on in main first :)

[castrojo]

I've got this on in Bluefin and a few others and it seems fine. Any other feedback from approvers?

[dosubot]

Hi, @noelmiller. I'm Dosu, and I'm helping the Main Repos team manage their backlog. I'm marking this issue as stale.

Issue Summary:

• You suggested integrating Codacy for code analysis to improve code quality.
• The plan includes refactoring container files into smaller bash scripts.
• @castrojo supports the idea and suggests testing Codacy in the Bluefin repository.
• Initial tests in Bluefin and other repositories show Codacy functioning well.
• Further feedback from other approvers is awaited.

Next Steps:

• Is this issue still relevant to the latest version of the Main Repos repository? If so, please comment to keep the discussion open.
• Otherwise, this issue will be automatically closed in 14 days.

Thank you for your understanding and contribution!