-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Enforce 64-bit version of mesa-va-drivers-freeworld #474
Conversation
Potentially solves an issue where, when rpmfusion is out of date, this will install the 32-bit version of the package and not fail as it should. As a result, this PR should fail to build until the package is built upstream.
Confirmed this fails to build, marking as ready for review as a result. This won't merge unless everything builds successfully which is the intended behavior when RPMFusion is current. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This solution makes sense. I agree we'll have to get a little smarter about it when we eventually add aarch64
.
This is default included and is likely an earlier workaround for the same problem
FYI for @ublue-os/approver : please do not force merge this PR. It should only be merged once a full set of clean build checks can run. |
And... in Discord Jorge, Kyle, Noel and I discussed further. We wanted to avoid breaking builds with this PR, but, all builds are now broken due to upstream Fedora/RPMfusion package updates. So this seems a good time to merge as we won't break things worse, but should get a clean build once the dust settles. So this can now be force merged. |
BAH GOD IT'S KYLE WITH A STEEL FORCE MERGE |
Potentially solves an issue where, when rpmfusion is out of date, this will install the 32-bit version of the package and not fail as it should.
As a result, this PR should fail to build until the package is built upstream. We'd rather not update than update w/ broken builds.