Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable Nvidia driver builds for v535 #122

Merged
merged 8 commits into from
Jun 24, 2023

Conversation

p5
Copy link
Member

@p5 p5 commented Jun 18, 2023

This PR makes the required changes to build the v535 NVIDIA drivers.

This can be merged when the packages have been released. You can see which repos each package is in here
https://rpmfind.net/linux/rpm2html/search.php?query=akmod-nvidia

Comment on lines 23 to 34
driver_version: [470, 520, 525, 530, 535]
exclude:
- driver_version: 525
major_version: 37
- driver_version: 525
- driver_version: 470
major_version: 38
- driver_version: 520
major_version: 37
- driver_version: 520
major_version: 38
- driver_version: 470
- driver_version: 525
major_version: 37
- driver_version: 525
major_version: 38
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My OCD needed to fix the ordering of these... Both lists are now from oldest to newest :)

build.sh Outdated Show resolved Hide resolved
install.sh Outdated Show resolved Hide resolved
@p5 p5 changed the title Enable driver builds for v535 feature: Enable driver builds for v535 Jun 18, 2023
@@ -20,18 +20,12 @@ jobs:
fail-fast: false
matrix:
major_version: [37, 38]
driver_version: [520, 525, 530, 470]
driver_version: [470, 530, 535]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removes the v520 and v525 drivers since they are being excluded for both Fedora versions

@p5
Copy link
Member Author

p5 commented Jun 18, 2023

I don't want this merging until v535 has been released to the regular repos and we've removed the sed commands which enable testing repos

@p5 p5 changed the title feature: Enable driver builds for v535 feat: Enable driver builds for v535 Jun 23, 2023
@p5 p5 marked this pull request as ready for review June 23, 2023 20:09
@p5 p5 requested review from joshua-stone and castrojo June 23, 2023 20:11
@p5 p5 changed the title feat: Enable driver builds for v535 feat: Enable Nvidia driver builds for v535 Jun 23, 2023
@p5
Copy link
Member Author

p5 commented Jun 23, 2023

AFAICT, v535 has been released to the proper repos, so I have updated this PR and made it ready to merge.

Only issue is Fedora 37 builds are failing, but I don't think that's due to any of my changes

Copy link
Member

@EyeCantCU EyeCantCU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything here looks good to me now that 535 is in stable. The cleanup of older driver versions is also nice. Thank you!

@MiMillieuh
Copy link

AFAICT, v535 has been released to the proper repos, so I have updated this PR and made it ready to merge.

Only issue is Fedora 37 builds are failing, but I don't think that's due to any of my changes

This is due to the lack of the 530 driver in the F37 repo.

F37 RPMfusion has a 520 base and the update keeps only the latest driver so that means that Nvidia driver versions available for F37 are 340, 390, 520, 535

On the other hand F38 can be build with the 530 driver cause that the base driver version. so version that are available for F38 are 340, 390, 530, 535

That situation is normal and will happen each Nvidia driver update. the same issue will occurs if you try to keep 535 version on F38 when a newer version will be released.

In short terms you need to drop 530 for fedora 37 it won't build any more so that's pointless.

See pkgs.org to look for the avalible packages by yourself : https://pkgs.org/download/akmod-nvidia

Also you can check on the F36 repo that has literally the same behavior

- driver_version: 520
major_version: 37
- driver_version: 520
major_version: 38
- driver_version: 470
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exclude builds of 37 with driver version 530 here

- driver_version: 530
  major_version: 37

Copy link

@MiMillieuh MiMillieuh Jun 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you still wants some legacy in your version you can keep the 520 driver on fedora 37 cause it's the base driver so it will always be possible to build it.

However don't enable it on F38 cause the driver doesn't exists.

Copy link
Member Author

@p5 p5 Jun 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes made in 182798f

I don't think we need to worry about enabling an older driver version in this PR - this was mainly just getting the new ones to build. I was hoping this would be a non-breaking update, but it turns out it broke on it's own.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure that's fine to keep the latest only.

I was just saying this so you know what's possible to do or not in the current situation it might help understanding for the future so that kind of issue won't happen any more.

@p5 p5 requested a review from MiMillieuh June 24, 2023 15:47
@EyeCantCU EyeCantCU enabled auto-merge June 24, 2023 16:11
@castrojo castrojo disabled auto-merge June 24, 2023 16:28
@castrojo castrojo enabled auto-merge June 24, 2023 16:28
@castrojo castrojo disabled auto-merge June 24, 2023 16:29
@castrojo castrojo merged commit fc8c211 into ublue-os:main Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants