Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve status controller #5

Open
aldoborrero opened this issue Mar 14, 2018 · 0 comments
Open

Improve status controller #5

aldoborrero opened this issue Mar 14, 2018 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@aldoborrero
Copy link
Member

Right now status controller is a fake service that will display ok in all networks (just to have Sparrow passing in their checks).

Would be awesome to think a good way of checking the status of the nodes.

Possible way of doing it is using docker healthcheck (https://howchoo.com/g/zwjhogrkywe/how-to-add-a-health-check-to-your-docker-container)

Also we should make sure that the checks are passing in tests.

@aldoborrero aldoborrero added this to the Milestone-1.0.0 milestone Mar 14, 2018
@aldoborrero aldoborrero added enhancement New feature or request help wanted Extra attention is needed in progress and removed in progress labels Mar 14, 2018
@aldoborrero aldoborrero changed the title Improve status controller (and add proper tests) Improve status controller Mar 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant