Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add form elements #9

Merged
merged 6 commits into from
Oct 2, 2023
Merged

add form elements #9

merged 6 commits into from
Oct 2, 2023
+452 −22

Conversation

takanorip
Copy link
Contributor

  • Select
  • Radio Button
  • TextArea

@takanorip takanorip self-assigned this Sep 26, 2023
@takanorip takanorip marked this pull request as ready for review September 26, 2023 15:23
@takanorip takanorip marked this pull request as draft September 26, 2023 18:35
@takanorip takanorip marked this pull request as ready for review September 26, 2023 20:31
8845musign
8845musign reviewed Sep 28, 2023
View reviewed changes
Copy link
Collaborator

@8845musign 8845musign left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also tested it with Mac/VoiceOver briefly.
It seems to work fine💪

src/components/RadioButton/RadioButton.module.css Outdated Show resolved Hide resolved
src/components/RadioButton/RadioButton.module.css Show resolved Hide resolved
src/components/Checkbox/Checkbox.module.css Show resolved Hide resolved
src/components/Select/Select.tsx Show resolved Hide resolved
src/components/Select/Select.module.css Show resolved Hide resolved
8845musign
8845musign reviewed Sep 28, 2023
View reviewed changes
src/components/Checkbox/Checkbox.module.css
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find the style for disabled.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed!

8845musign
8845musign approved these changes Oct 2, 2023
View reviewed changes
Copy link
Collaborator

@8845musign 8845musign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@takanorip takanorip merged commit 07d1aa1 into main Oct 2, 2023
2 checks passed
@takanorip takanorip deleted the add-inputs branch October 2, 2023 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@8845musign 8845musign 8845musign approved these changes

Assignees

@takanorip takanorip

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@takanorip @8845musign