Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add chromatic command #136

Merged
merged 3 commits into from
Sep 24, 2024
Merged

add chromatic command #136

merged 3 commits into from
Sep 24, 2024

Conversation

takanorip
Copy link
Contributor

@takanorip takanorip commented Sep 20, 2024

Changes

  • add chromatic script
  • add CI

https://www.chromatic.com/builds?appId=66505237ba1f5318fc8cf57b

Check

  • Browser verification (minimum) Android Chrome/iOS Safari(375px-)
  • CSS not affected by inheritance
  • Layout does not break even if there is an overflow
  • Layout does not break when wraps
  • Added new Component
    • Added data-* prop and id prop
  • Updated Ubie Vitals or Added an update issue(if needed)

@8845musign
Copy link
Collaborator

ci/chromatic is error

Copy link
Collaborator

@8845musign 8845musign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@takanorip takanorip merged commit e0c35da into main Sep 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants