Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve text wrap #106

Merged
merged 3 commits into from
Jun 17, 2024
Merged

Improve text wrap #106

merged 3 commits into from
Jun 17, 2024

Conversation

8845musign
Copy link
Collaborator

@8845musign 8845musign commented Jun 14, 2024 •
edited
Loading

Changes

  • Support for components that primarily handle text
    • <Text>, <Heading>, <Box>, <Accordion>, <Checkbox>, <Button>, <ErrorMessage>, <HelperMessage>, <Label>, <LinkCard>, <RadioButton> and <RadioCard>
  • Wrap if overflow setting
    • Added noWrap option for<Text>, <Heading>, and <Box> to disable it.

Screenshot

Text

スクリーンショット 2024-06-14 13 41 56

Heading

スクリーンショット 2024-06-14 13 42 12

Box

スクリーンショット 2024-06-14 13 42 27

Check

  • Added new Component
    • Added data-* prop and id prop
  • Updated Ubie Vitals or Added an update issue(if needed)

@8845musign 8845musign marked this pull request as ready for review June 14, 2024 04:45
@8845musign 8845musign self-assigned this Jun 14, 2024
@takanorip takanorip merged commit 5d12e35 into ubie-oss:main Jun 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takanorip takanorip takanorip approved these changes

Assignees

@8845musign 8845musign

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@8845musign @takanorip