Skip to content

Commit dc480c0

Browse files
Merge pull request #233 from gandhikrishna/updatetchannel
Fixed Broken master, Updated tchannel-go to 1.32.0
2 parents 61092fb + 7896c45 commit dc480c0

40 files changed

+809
-49
lines changed

.github/workflows/test.yaml

+3-3
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
- name: Setup Go
1919
uses: actions/setup-go@v2
2020
with:
21-
go-version: 1.15
21+
go-version: 1.16.6
2222
- name: Setup Python 2.7
2323
uses: actions/setup-python@v2
2424
with:
@@ -52,7 +52,7 @@ jobs:
5252
./scripts/travis/get-cram.sh
5353
npm install -g [email protected]
5454
- name: Run Setup
55-
run: make setup
55+
run: make setup
5656
- name: Lint
5757
run: make lint
5858
- name: Unit Tests
@@ -64,6 +64,6 @@ jobs:
6464
- name: Generate coverage report
6565
run: make coveralls
6666
- name: Upload coverage report
67-
uses: shogo82148/actions-goveralls@v1
67+
uses: shogo82148/actions-goveralls@02a150c2be8d92067983c74e9be237da98abfaad
6868
with:
6969
path-to-profile: ${{ env.GOPATH }}/src/github.com/${{ github.repository }}/acc.out

Makefile

-1
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@ mocks:
5252
dev_deps:
5353
go get -u github.com/uber/tchannel-go/thrift/thrift-gen
5454
go get -u golang.org/x/lint/golint/...
55-
./scripts/go-get-version.sh github.com/vektra/mockery/.../@130a05e
5655

5756
setup: dev_deps
5857
glide install

examples/keyvalue/gen-go/keyvalue/constants.go

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

examples/keyvalue/gen-go/keyvalue/keyvalueservice.go

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

examples/keyvalue/gen-go/keyvalue/tchan-keyvalue.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ package keyvalue
66
import (
77
"fmt"
88

9-
athrift "github.com/apache/thrift/lib/go/thrift"
9+
athrift "github.com/uber/tchannel-go/thirdparty/github.com/apache/thrift/lib/go/thrift"
1010
"github.com/uber/tchannel-go/thrift"
1111
)
1212

examples/keyvalue/gen-go/keyvalue/ttypes.go

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

examples/ping-thrift-gen/gen-go/ping/constants.go

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

examples/ping-thrift-gen/gen-go/ping/pingpongservice.go

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

examples/ping-thrift-gen/gen-go/ping/tchan-ping.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ package ping
66
import (
77
"fmt"
88

9-
athrift "github.com/apache/thrift/lib/go/thrift"
9+
athrift "github.com/uber/tchannel-go/thirdparty/github.com/apache/thrift/lib/go/thrift"
1010
"github.com/uber/tchannel-go/thrift"
1111
)
1212

examples/ping-thrift-gen/gen-go/ping/ttypes.go

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

examples/ping-thrift/gen-go/ping/constants.go

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

examples/ping-thrift/gen-go/ping/pingpongservice.go

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

examples/ping-thrift/gen-go/ping/tchan-ping.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ package ping
66
import (
77
"fmt"
88

9-
athrift "github.com/apache/thrift/lib/go/thrift"
9+
athrift "github.com/uber/tchannel-go/thirdparty/github.com/apache/thrift/lib/go/thrift"
1010
"github.com/uber/tchannel-go/thrift"
1111
)
1212

examples/ping-thrift/gen-go/ping/ttypes.go

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

examples/role-labels/gen-go/role/constants.go

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

examples/role-labels/gen-go/role/roleservice.go

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

examples/role-labels/gen-go/role/tchan-role.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ package role
66
import (
77
"fmt"
88

9-
athrift "github.com/apache/thrift/lib/go/thrift"
9+
athrift "github.com/uber/tchannel-go/thirdparty/github.com/apache/thrift/lib/go/thrift"
1010
"github.com/uber/tchannel-go/thrift"
1111
)
1212

examples/role-labels/gen-go/role/ttypes.go

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

forward/forwarder_test.go

+1-2
Original file line numberDiff line numberDiff line change
@@ -31,12 +31,12 @@ import (
3131
events "github.com/uber/ringpop-go/events/test/mocks"
3232
"github.com/uber/ringpop-go/test/thrift/pingpong"
3333

34-
athrift "github.com/apache/thrift/lib/go/thrift"
3534
"github.com/stretchr/testify/assert"
3635
"github.com/stretchr/testify/mock"
3736
"github.com/stretchr/testify/suite"
3837
"github.com/uber/tchannel-go"
3938
"github.com/uber/tchannel-go/json"
39+
athrift "github.com/uber/tchannel-go/thirdparty/github.com/apache/thrift/lib/go/thrift"
4040
"github.com/uber/tchannel-go/thrift"
4141
"golang.org/x/net/context"
4242
)
@@ -219,7 +219,6 @@ func (s *ForwarderTestSuite) TestForwardThriftWithCtxOption() {
219219
bytes1, err := SerializeThrift(request)
220220
s.NoError(err, "expected ping to be serialized")
221221

222-
223222
k := ContextKey("key")
224223
ctx := thrift.Wrap(context.WithValue(context.Background(), k, "val"))
225224

glide.lock

+10-12
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

glide.yaml

+3-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ import:
1616
- require
1717
- package: github.com/uber-common/bark
1818
- package: github.com/uber/tchannel-go
19-
version: 1.8.0
19+
version: 1.32.0
2020
subpackages:
2121
- json
2222
- raw
@@ -25,3 +25,5 @@ import:
2525
- package: golang.org/x/net
2626
subpackages:
2727
- context
28+
- package: golang.org/x/sys
29+
version: master

ringpop.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -38,11 +38,11 @@ import (
3838
"github.com/uber/ringpop-go/shared"
3939
"github.com/uber/ringpop-go/swim"
4040

41-
athrift "github.com/apache/thrift/lib/go/thrift"
4241
"github.com/benbjohnson/clock"
4342
"github.com/dgryski/go-farm"
4443
log "github.com/uber-common/bark"
4544
"github.com/uber/tchannel-go"
45+
athrift "github.com/uber/tchannel-go/thirdparty/github.com/apache/thrift/lib/go/thrift"
4646
)
4747

4848
// Interface specifies the public facing methods a user of ringpop is able to

test/mocks/t_chan_client.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ package mocks
33
import "github.com/uber/tchannel-go/thrift"
44
import "github.com/stretchr/testify/mock"
55

6-
import athrift "github.com/apache/thrift/lib/go/thrift"
6+
import athrift "github.com/uber/tchannel-go/thirdparty/github.com/apache/thrift/lib/go/thrift"
77

88
type TChanClient struct {
99
mock.Mock

test/remoteservice/.gen/go/remoteservice/constants.go

+23
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)