Skip to content

React node/edges elements are not umounted? #321

@adamzapasnik

Description

@adamzapasnik

Describe the bug
I notice that when I delete an edge or a node there is still a corresponding react element in react extension's Components view (or whatever you call it). It seems that you remove dom elements but you never call ReactDOM.unmountComponentAtNode. Is it on purpose? Isn't pretty much a memory leak? I could be wrong, so please explain why it's done this way.

To Reproduce
Steps to reproduce the behavior:

  1. Remove a node or an edge
  2. Look into react extension's Component sview
  3. Notice that there are still components "alive"

Expected behavior
They should be removed, I guess?

Screenshots
Screenshot 2021-06-08 at 22 15 41
Notice the NaNpx (an edge was removed, but the React component still exists?)

Desktop (please complete the following information):

  • OS: [e.g. iOS] macOs
  • Browser [e.g. chrome, safari] firefox/chrome
  • Version [e.g. 22] newest

Additional context
version 8.0.0-beta.6
node v14.17.0

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions