Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard against potential out-of-bounds lookups in base cell tables #392

Open
nrabinowitz opened this issue Sep 10, 2020 · 1 comment
Open
Labels

Comments

@nrabinowitz
Copy link
Collaborator

The functions in baseCells.c should guard against invalid base cell numbers that could result in out-of-bounds reads on the lookup tables.

@alexey-milovidov
Copy link
Contributor

alexey-milovidov commented Jan 17, 2021

For zero-cost implementation (safe but implementation specific behaviour on out-of-bounds lookup) we can simply extend the arrays to 128 elements (filling the rest with zeros).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants