Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H3-java newInstance() couldn't recover when the temporary dynamic library file is deleted #58

Closed
boyxgc opened this issue Jan 7, 2020 · 2 comments

Comments

@boyxgc
Copy link
Contributor

boyxgc commented Jan 7, 2020

When newing an H3Core instance, the function copies the dynamic library from resources to a temporary file in order to load the libraries and reuses the original temporary file for newing instances later.

In the event that the temporary file is deleted, creating new instances always crashes with no way to recover.

I suggest we add a file existence check to the existing file path and recreate if needed.

@isaacbrodsky
Copy link
Collaborator

I think adding a file existence check makes sense. There will still be a race condition where the file is determined to exist and then is deleted (unless catching the file not found exception)

@boyxgc
Copy link
Contributor Author

boyxgc commented Jan 13, 2020

This is fixed in the v3.6.3 release.

@boyxgc boyxgc closed this as completed Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants