Improve package mode performance #230
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
johanneswuerbach
commented
Jan 3, 2025
|
|
||
| cfg := &packages.Config{ | ||
| Mode: packages.NeedDeps | packages.NeedImports | packages.NeedTypes | packages.NeedTypesInfo | packages.NeedEmbedFiles | packages.LoadSyntax, | ||
| Mode: packages.LoadSyntax, |
Author
There was a problem hiding this comment.
This was simplified according to https://pkg.go.dev/golang.org/x/tools/go/packages#pkg-constants, which states that LoadSyntax is essentially all other options except NeedDeps and NeedEmbedFiles.
Not sure why NeedEmbedFiles was used here, but NeedDeps is the biggest performance hit and the tests are still passing with it being removed and our mocks are generated just fine.
There was a problem hiding this comment.
2025/03/18 13:14:21 internal error: package "encoding/json" without types was imported from "<package>"
We've just run into the (in our case) 2x performance degradation (15m -> 30m), unfortunately this change (specifically the removal of NeedDeps) doesn't seem to work as we're unable to find types for the third party packages that we're using.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of loading the package and all its dependencies, load only the specified package, which significantly improves the performance in our case.