Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule in a logger should be clickable and provide the link to the search #207

Closed
5 of 8 tasks
KOLANICH opened this issue Sep 6, 2018 · 3 comments
Closed
5 of 8 tasks
Labels
declined declined enhancement New feature or request

Comments

@KOLANICH
Copy link

KOLANICH commented Sep 6, 2018

Prerequisites

  • I verified that this is not a filter issue
  • This is not a support issue or a question
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue
    • Your issue may already be reported.
  • I tried to reproduce the issue when...
    • uBlock Origin is the only extension
    • uBlock Origin with default lists/settings
    • using a new, unmodified browser profile
  • I am running the latest version of uBlock Origin
  • I checked the documentation to understand that the issue I report is not a normal behavior

Description

Rule in the logger should be clickable, the link should point to the line rule is defined.

@uBlock-user uBlock-user added the enhancement New feature or request label Sep 6, 2018
@gorhill
Copy link
Member

gorhill commented Sep 6, 2018

Filters in the logger won't be clickable because uBO has no idea from where a filter comes from before you click on it -- because an expensive reverse lookup is used when clicking the filters to find out all the filter lists which declare the filter.

However I believe I could link to the line in each filter lists found to contain the filter, such that clicking on it will cause the asset viewer to move to the line.

@KOLANICH
Copy link
Author

KOLANICH commented Sep 6, 2018

Filters in the logger won't be clickable because uBO has no idea from where a filter comes from before you click on it

I know, but we can start a search on demand (#205) , that's why the word search is in the issue title.

I mean that every rule in a logger is a link, but this link points to the search of that rule, and if the rule is defined in a single place, it behaves like "I'm feeling lucky", otherwise it shows the search results.

@gorhill
Copy link
Member

gorhill commented Sep 7, 2018

However I believe I could link to the line in each filter lists found to contain the filter, such that clicking on it will cause the asset viewer to move to the line.

I will decline implementing this for the time being, this would require to save an offset into the compile filter lists for each filter, meaning a larger compiled filter lists, and I don't think it's worth it at this point where I have done work to actually shrink size of data saved in cache storage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
declined declined enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants