Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter combining inconsistency between blockers #1725

Closed
peace2000 opened this issue Sep 19, 2021 · 2 comments
Closed

Filter combining inconsistency between blockers #1725

peace2000 opened this issue Sep 19, 2021 · 2 comments
Labels
discussion weighing in community's input on a specific topic

Comments

@peace2000
Copy link
Member

peace2000 commented Sep 19, 2021

I have noticed that there is an inconsistency between blockers when combining filters with a comma.

Adblock Plus, Adguard and uBlock Origin treat filters like this differently:

iltalehti.fi#?#main div[class="card "], main .half-article:-abp-contains(Kaupallinen yhteistyö)

ABP & uBO way to interpret:

iltalehti.fi#?#main div[class="card "]:-abp-contains(Kaupallinen yhteistyö)
iltalehti.fi#?#main .half-article:-abp-contains(Kaupallinen yhteistyö)

AG way to interpret:
iltalehti.fi#?#main div[class="card "]
iltalehti.fi#?#main .half-article:-abp-contains(Kaupallinen yhteistyö)

I'm not aware of any common place to discuss stuff like this so I'm opening an issue report here, and I'll tag representatives from each "section": @gorhill @ameshkov @WebReflection

What I'm trying to say is that could you consider doing some alignment/agreeing together how rules like that should be interpret so that it's interpret in the same way in all blockers? For those who try to maintain cross-blocker compatible filterlists, inconsistencies in interpretation are not a good thing.

Page where I tested filter interpretation: https://www.iltalehti.fi/raha

@gwarser
Copy link

gwarser commented Sep 19, 2021

#382 (comment)


Actually this one issue was linked from wiki #453 it's about comma-separated procedurals, not only :style().

@gorhill
Copy link
Member

gorhill commented Sep 19, 2021

I'm not aware of any common place to discuss stuff like this

Please open a discussion about this, I want the issue tracker to be kept for actionable items.

@gorhill gorhill closed this as completed Sep 19, 2021
@uBlockOrigin uBlockOrigin locked and limited conversation to collaborators Sep 19, 2021
@uBlock-user uBlock-user added the discussion weighing in community's input on a specific topic label Sep 19, 2021

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
discussion weighing in community's input on a specific topic
Projects
None yet
Development

No branches or pull requests

4 participants