Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Right-click block support #269

Open
foxt opened this issue Jan 22, 2025 · 8 comments
Open

[Request] Right-click block support #269

foxt opened this issue Jan 22, 2025 · 8 comments
Labels
enhancement New feature or request

Comments

@foxt
Copy link

foxt commented Jan 22, 2025

Hello,
Is there any plan to add the right-click block element feature present in uBO (full) to uBO Lite? Extensions like Stylus are MV3 compliant so I assume it would be possible if you're willing.

Thanks in advance

@stephenhawk8054
Copy link
Member

What options do you want to do with uBOL when right clicking? uBOL does not support custom filters.

@foxt
Copy link
Author

foxt commented Jan 22, 2025

What options do you want to do with uBOL when right clicking?

@stephenhawk8054 Just like in main uBO, where you can right click, select "Block element" and it will prevent elements element matching a CSS selector from appearing

@stephenhawk8054
Copy link
Member

As said

uBOL does not support custom filters.

@foxt
Copy link
Author

foxt commented Jan 22, 2025

Got it, please keep this in mind if you ever change your mind, but regardless I'd like to thank you and any of the other uBO maintainers for your hard work over the years

@foxt foxt closed this as completed Jan 22, 2025
@MasterKia MasterKia added the duplicate This issue or pull request already exists label Jan 23, 2025
@gorhill
Copy link
Member

gorhill commented Jan 23, 2025

I have given thoughts on a “Block element…” feature, and I believe it’s possible while keeping the current declarative approach. The idea is to register a navigation listener only for the sites for which there are custom cosmetic filters, I.e. the service worker would wake up only for the sites for which there are custom cosmetic filters, and people with no custom filters would be unaffected.

@stephenhawk8054
Copy link
Member

So, is it possible to expand it to scriptlets as well?

@gwarser
Copy link

gwarser commented Jan 23, 2025

And for the toolbar icon.

@krystian3w
Copy link

krystian3w commented Jan 31, 2025

So, is it possible to expand it to scriptlets as well?

I think we can then get the same blocking as AdGuard MV3, scriptlets no longer work there from the my "filters" tab (it remains to be seen whether Adblock Plus MV3 will be similarly limited).

@MasterKia MasterKia reopened this Jan 31, 2025
@MasterKia MasterKia added enhancement New feature or request and removed duplicate This issue or pull request already exists labels Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants