Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x.com: ads #23732

Closed
11 tasks done
BRR34L0RD opened this issue May 17, 2024 · 9 comments
Closed
11 tasks done

x.com: ads #23732

BRR34L0RD opened this issue May 17, 2024 · 9 comments

Comments

@BRR34L0RD
Copy link

Prerequisites

  • This is NOT a YouTube, Facebook, Twitch or a shortener/hosting site report. These sites MUST be reported by clicking their respective links.
  • I read and understand the policy about what is a valid filter issue.
  • I verified that this issue is not a duplicate. (Use this button to find out.)
  • I did not remove any of the default filter lists, or I have verified that the issue was not caused by removing any of the default lists.
  • I did not enable additional filter lists, or I have verified that the issue still occurs without enabling additional filter lists.
  • I do not have custom filters/rules, or I have verified that the issue still occurs without custom filters/rules.
  • I am not using uBlock Origin along with other content blockers.
  • I have verified that the web browser's built-in content blocker/tracking protection, network wide/DNS blocking, or my VPN is not causing the issue.
  • I have verified that other extensions are not causing the issue.
  • If this is about a breakage or detection, I have verified that it is caused by uBlock Origin and isn't a site issue.
  • I did not answer truthfully to ALL the above checkboxes.

URL address of the web page

https://x.com/i/verified-get-verified

Category

ads

Description

An annoying nag screen appears whenever I block a sponsored tweet.

Other extensions used

Nothing.

Screenshot(s)

Screenshot(s)

image

Configuration

uBlock Origin: 1.57.2
Firefox: 126
filterset (summary):
 network: 136328
 cosmetic: 50694
 scriptlet: 19848
 html: 1787
listset (total-discarded, last-updated):
 default:
  user-filters: 53-14, never
  ublock-filters: 38100-110, now
  ublock-badware: 8579-0, now
  ublock-privacy: 909-2, now
  ublock-unbreak: 2333-2, now
  ublock-quick-fixes: 195-5, now
  easylist: 87463-160, now
  easyprivacy: 50919-67, now
  urlhaus-1: 12505-2, now
  plowe-0: 3729-1160, now
  spa-1: 5634-88, now
filterset (user): [array of 53 redacted]
trustedset:
 added: [array of 6 redacted]
switchRuleset:
 added: [array of 1 redacted]
userSettings: [none]
hiddenSettings: [none]
supportStats:
 allReadyAfter: 718 ms (selfie)
 maxAssetCacheWait: 105 ms
 cacheBackend: indexedDB
popupPanel:
 blocked: 4
 network:
  ads-twitter.com: 1
  google-analytics.com: 1
  twitter.com: 2
@loadstring1
Copy link

ublock filters need to be updated to x.com

they recently redirected from twitter.com to x.com domain

@stephenhawk8054
Copy link
Member

stephenhawk8054 commented May 17, 2024

ublock filters need to be updated to x.com

they recently redirected from twitter.com to x.com domain

It's already updated: f93e44f

@loadstring1

This comment was marked as resolved.

@loadstring1

This comment was marked as resolved.

@Yuki2718
Copy link
Contributor

Yuki2718 commented May 17, 2024

@gorhill Not related to this issue, but Can you publish a new version of uBOL ASAP for the domain change?


I think having no way to quickly fix mega-sites like Twitter, youtube is not good mentally. A lot of user will move to uBOL the next month, and people will cry when they see ads or breakage on them. We can only hope you can respond quickly in such cases.
uBlockOrigin/uBOL-home#108 (comment)

@gorhill
Copy link
Member

gorhill commented May 17, 2024

having no way to quickly fix mega-sites like Twitter, youtube is not good mentally

The fixes to Twitter mostly relate to cosmetic filters, these cannot be updated dynamically (neither scriptlets). MV3 dynamic filters is only for network filters, not very useful when a big share of filter changes are cosmetic- or scriptlet-based filters.

@BRR34L0RD
Copy link
Author

As I said, I saw a sponsored tweet, I tried to block the user (in reticenses menu), and after this, the nag screen (as shown in screenshot) appears. I will do more tests, if I won't respond, the issue was solved.

@Yuki2718
Copy link
Contributor

Yuki2718 commented Jul 16, 2024

The fixes to Twitter mostly relate to cosmetic filters, these cannot be updated dynamically (neither scriptlets). MV3 dynamic filters is only for network filters, not very useful when a big share of filter changes are cosmetic- or scriptlet-based filters.

As DNR is only about network filters, why can cosmetic filters not be updated dynamically? @Alex-302 said custom filters in AGMV3 can update cosmetic filters dynamically, though is not implmented yet.

@gorhill
Copy link
Member

gorhill commented Jul 17, 2024

why can cosmetic filters not be updated dynamically?

Because they are injected declaratively through scripting.registerContentScript().

Sure, they can be injected dynamically but this would require the following sequence to take place:

  • Page loads
  • Worker wakes up if not active: this adds delay along with (possibly severe) CPU and memory spike
  • Find matching cosmetic filters
  • Apply matching filters

The big issue is the wake up of the extension's service worker, which adds delay, which will produce a delay before the cosmetic filters are applied. I chose to go the reliable route for cosmetic and scriplet filtering by relying completely on the declarative approach. I demonstrate here the delay and CPU-/memory-spike issue: https://github.com/uBlockOrigin/uBOL-home/wiki/Frequently-asked-questions-(FAQ)#is-ubo-lite-a-bad-faith-attempt-at-converting-ubo-to-mv3 -- I can add the same sort of demonstration for cosmetic filters.

Also, the non-declarative approach requires to put in all the code responsible for compiling/storing filters, a sizeable amount of code.

I chose the reliable and lean approach, hence the limitations. Whoever wants more than what uBO Lite offers will have to find another solution, uBO Lite is not for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants