Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update graphql.json #964

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update graphql.json #964

wants to merge 2 commits into from

Conversation

ashleydw
Copy link

Typings URL: https://github.com/nitintutlani/typed-graphql/

Change Summary (for existing typings):

There's no changelog available from the source repo, but looking at the commit history it is largely bug fixes with some additions.

@blakeembrey
Copy link
Member

blakeembrey commented Feb 13, 2017

It looks like that module was changed to be a global definition in nitintutlani/typed-graphql@b773a00. The commit alludes to "TypeScript 2.0" support, but I'm not sure the author understood what TypeScript 2.0 module resolution with NPM was since the change they made was definitely not required (TypeScript 2.0 just allows the NPM @types namespace which still uses external modules, module resolution that they added has existed in TypeScript since when Typings was released - since 1.5).

blakeembrey referenced this pull request in nitintutlani/typed-graphql Feb 13, 2017
@blakeembrey
Copy link
Member

It seems we should be able to bump this commit anytime you'd like now 😄

@ashleydw
Copy link
Author

ashleydw commented Mar 2, 2017

I've bumped the PR version up. If you can squash the merge that would save me starting a new PR :)

@blakeembrey
Copy link
Member

@ashleydw Actually, I was wrong. Sorry, I only looked at the comment and not the code itself - it seems they didn't fix the issue and just moved stuff around instead (nitintutlani/typed-graphql@6e0f325).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants