adding chai-xml #313
Closed
adding chai-xml #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 13, 2016 11:10
|
@rhysawilliams2010 I can't merge this because of the augmentation of the namespace hack instead of the real name. Unfortunately, I know that's currently the only way to make it work. It's been discussed in #270 (comment) and the fix is currently blocked by a compiler issue in TypeScript. I'll let you know when it's fixed and we can merge. |
added 4 commits
April 21, 2016 13:35
|
I have changed the branch on my fork for this PR. There is a new PR here which i have already closed: #344 . I can reopen later when I can make it less hacky. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typings URL: https://github.com/rhysawilliams2010/typings-chai-xml
Source URL: https://github.com/krampstudio/chai-xml