Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to ESLint's root: true to match TSLint behavior #1465

Closed
hyperupcall opened this issue Apr 29, 2022 · 1 comment · Fixed by #1467
Closed

Default to ESLint's root: true to match TSLint behavior #1465

hyperupcall opened this issue Apr 29, 2022 · 1 comment · Fixed by #1467
Labels
good first issue Good for newcomers; welcome aboard! status: accepting prs Please, send in a PR to resolve this! ✨ type: bug Something isn't working

Comments

@hyperupcall
Copy link
Contributor

🚀 Feature Request

To the best of my knowledge, tslint does not automatically search for and process tslint.json files that are in parent directories. ESLint does this by default, and needs to be disabled by specifying root: true at the configuration top-level. To match the default behavior of tslint, we could set this ESLint top-level property

If this feature request is accepted, I am able to make a PR

I can make a PR

Existing Behavior

Does not set root property of ESLint configuration

Change Proposal

Set top-level root to true in all generated configs

@JoshuaKGoldberg JoshuaKGoldberg added type: bug Something isn't working status: accepting prs Please, send in a PR to resolve this! ✨ good first issue Good for newcomers; welcome aboard! labels Apr 29, 2022
@JoshuaKGoldberg
Copy link
Member

That makes sense, good point! https://typescript-eslint.io/docs/linting also recommends setting root: true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers; welcome aboard! status: accepting prs Please, send in a PR to resolve this! ✨ type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants