Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generator kills Cmder due to missing name and version in package.json #55

Closed
OlsonDev opened this issue Apr 5, 2016 · 6 comments
Closed

Comments

@OlsonDev
Copy link
Contributor

OlsonDev commented Apr 5, 2016

I just ran into cmderdev/cmder#700 from running this generator. The root of the issue is package.json is missing a "name" and "version". After I manually added those, new Cmder instances could be cd'd into my directory.

Obviously this isn't your issue, but I am curious if "name" and "version" could be defaulted?

image

@OlsonDev
Copy link
Contributor Author

OlsonDev commented Apr 5, 2016

I'm also guessing "description" could be defaulted -- I believe npm will complain about it.

@unional
Copy link
Collaborator

unional commented Apr 5, 2016

Yeah, originally I do have name, version and description, but then took it out as @blakeembrey suggest to keep it minimal.

If it is an issue on certain environment, probably would consider adding those back it.

@blakeembrey
Copy link
Collaborator

@OlsonDev No need for name, version or description in package.json. They are just more stuff you'd need to keep up to date.

@blakeembrey
Copy link
Collaborator

@unional I see a typo in the screenshot - should be DefinitelyTyped (with a trailing "d").

@OlsonDev
Copy link
Contributor Author

OlsonDev commented Apr 5, 2016

@blakeembrey I already addressed that typo. See #54 🌹

@OlsonDev
Copy link
Contributor Author

OlsonDev commented Apr 5, 2016

No need for name, version or description in package.json. They are just more stuff you'd need to keep up to date.

@blakeembrey Fair enough; I'll just use cmd.exe till there's a release of Cmder with that Lua script fixed. 😢

@OlsonDev OlsonDev closed this as completed Apr 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants