Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OtelJava.noop() #542

Closed
fugafree opened this issue Mar 10, 2024 · 2 comments · Fixed by #543
Closed

Add OtelJava.noop() #542

fugafree opened this issue Mar 10, 2024 · 2 comments · Fixed by #543

Comments

@fugafree
Copy link

This is about having one single method to be able to initiate a no-op OtelJava, by calling OtelJava.noop(). The method is already available for OpenTelemetrySdk, Meter, MeterProvider and so on, but does not exists yet for OtelJava. And since its constructor is private, no chance the create one easily.

@NthPortal
Copy link
Contributor

@fugafree what's the use case specifically for a no-op OtelJava, rather than just using the noop implicits for Tracer and Meter? the primary issue with having a no-op OtelJava is that the LocalContext can't really be no-op.

Incidentally, you can always do: OtelJava.forAsync(JOpenTelemetry.noop())

@fugafree
Copy link
Author

@NthPortal I left a note on the PR itself to have all ideas at one place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants