Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MonadError instance for Kleisli #1701

Closed
anler opened this issue May 25, 2017 · 5 comments
Closed

MonadError instance for Kleisli #1701

anler opened this issue May 25, 2017 · 5 comments
Labels
low-hanging fruit

Comments

@anler
Copy link

anler commented May 25, 2017 •
edited
Loading

Hello! I was looking for a MonadError instance for Kleisli but I saw it doesn't exist, any particular reason for not having it? I had to write one myself because I have a transformer that is ReaderT[F, Env, A] and I require an evidence for MonadError[F, Throwable] (to handle unexpected exceptions when interfacing with imperative code)

Thanks!
@kailuowang
Copy link
Contributor

kailuowang commented May 25, 2017 •
edited
Loading

No particular reasons for its missing other than we didn't get to it yet. If you want, a PR will be more than welcome, otherwise, I can try add it before the next 1.0.0-MF release.

@kailuowang kailuowang added this to the 1.0.0-MF milestone May 25, 2017
@anler
Copy link
Author

anler commented May 25, 2017

Oh great! I'll grab this low-hanging-fruit and send you a PR ^^

@anler
Copy link
Author

anler commented May 25, 2017

Nevermind, I found that the instance was already added in #1618 by @peterneyens 🙂
Thanks!

@anler anler closed this as completed May 25, 2017
@kailuowang
Copy link
Contributor

kailuowang commented May 25, 2017 •
edited
Loading

sorry my bad
I found it too. https://github.com/typelevel/cats/blob/master/core/src/main/scala/cats/data/Kleisli.scala#L230

@kailuowang
Copy link
Contributor

the next release should be soon 🤞

@kailuowang kailuowang removed this from the 1.0.0-MF milestone May 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
low-hanging fruit
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kailuowang @anler