Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change how we use DjangoContext after https://github.com/typeddjango/django-stubs/pull/1557 #432

Closed
sobolevn opened this issue Jun 21, 2023 · 2 comments · Fixed by #433
Labels
bug Something isn't working

Comments

@sobolevn
Copy link
Member

sobolevn commented Jun 21, 2023

The signature of DjangoContext is changed in the linked PR (typeddjango/django-stubs#1557), so we would need to change the source code here:

django_settings_module = DjangoPluginConfig(options.config_file).django_settings_module
self.django_context = DjangoContext(django_settings_module)

And bump the django-stubs minimal version support.

@intgr
Copy link
Contributor

intgr commented Jun 22, 2023

Can you create a pull request for djangorestframeworks-stubs too?

To test it you can change requirements.txt to point to your django-stubs branch.

@sobolevn
Copy link
Member Author

Hm, I think we would need a compat layer: because of how django-stubs dep is specified: https://github.com/typeddjango/djangorestframework-stubs/blob/master/setup.py#L24

I will do it right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging a pull request may close this issue.

2 participants