Add t2 rpc methods #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks so much for the PR @adpthegreat, this looks super promising! |
lgalabru
reviewed
Mar 19, 2025
| .map_err(|err| Error::invalid_params(format!("failed to get supply: {err:?}"))); | ||
|
|
||
| response | ||
| } |
There was a problem hiding this comment.
I believe we should first be checking if we have something locally, then fallback on fetching remote if we have nothing in our cache. Does that make sense?
Feel free to ping me on TG if you think a chat convo can help you build context faster!
There was a problem hiding this comment.
Yeah i just sent a message, found you on that solana devex telegram gc
lgalabru
reviewed
Mar 19, 2025
| }; | ||
|
|
||
| println!("this is the supply {:?}", res); //works | ||
| assert_eq!(res, expected_response); |
lgalabru
reviewed
Mar 19, 2025
|
Also @lgalabru i want to hear your thoughts on the get_epoch_schedule and the comment i made |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15
getTransactionCount has been implemented already
getRecentPerformance_samples has been implemented already
getSupply Done
getFirstAvailableBlock Done
getBlockTime Done
getBlock Done
getEpochSchedule
Was seeing some comments ->
// TODO: Refactoragave-validator wait-for-restart-windowto not require this method, so // it can be removed from rpc_minimaldoes it affectget_epoch_scheduletoo? I should just write the method using therpc_client?Also, writing the tests is a bit tricky, I just hardcoded the assertions against my local validator values, but I confirmed that the rpc client methods work
Please review @lgalabru