ledger: Propagate error for unable to replay bank 0 (anza-xyz#5200)

We currently .expect() which panics and reports a datapoint which adds
noise to the list of panics when looking at metrics. These can be
filtered out, but propagating the error is more proper anyways

Author: steviez

core/src/replay_stage.rs

@@ -9194,7 +9194,8 @@ pub(crate) mod tests {
             &recyclers,
             None,
             None,
-        );
+        )
+        .unwrap();
 
         // Mark block 1, 3, 4, 5 as duplicate
         blockstore.store_duplicate_slot(1, vec![], vec![]).unwrap();

ledger/src/bank_forks_utils.rs

@@ -58,6 +58,9 @@ pub enum BankForksUtilsError {
         path: PathBuf,
     },
 
+    #[error("failed to process blockstore from genesis: {0}")]
+    ProcessBlockstoreFromGenesis(#[source] BlockstoreProcessorError),
+
     #[error("failed to process blockstore from root: {0}")]
     ProcessBlockstoreFromRoot(#[source] BlockstoreProcessorError),
 }
@@ -195,7 +198,8 @@ pub fn load_bank_forks(
                 entry_notification_sender,
                 accounts_update_notifier,
                 exit,
-            );
+            )
+            .map_err(BankForksUtilsError::ProcessBlockstoreFromGenesis)?;
             bank_forks
                 .read()
                 .unwrap()

ledger/src/blockstore_processor.rs

@@ -859,6 +859,9 @@ pub enum BlockstoreProcessorError {
     #[error("failed to load meta")]
     FailedToLoadMeta,
 
+    #[error("failed to replay bank 0, did you forget to provide a snapshot")]
+    FailedToReplayBank0,
+
     #[error("invalid block error: {0}")]
     InvalidBlock(#[from] BlockError),
 
@@ -994,7 +997,7 @@ pub(crate) fn process_blockstore_for_bank_0(
     entry_notification_sender: Option<&EntryNotifierSender>,
     accounts_update_notifier: Option<AccountsUpdateNotifier>,
     exit: Arc<AtomicBool>,
-) -> Arc<RwLock<BankForks>> {
+) -> result::Result<Arc<RwLock<BankForks>>, BlockstoreProcessorError> {
     // Setup bank for slot 0
     let bank0 = Bank::new_with_paths(
         genesis_config,
@@ -1027,8 +1030,9 @@ pub(crate) fn process_blockstore_for_bank_0(
         &VerifyRecyclers::default(),
         block_meta_sender,
         entry_notification_sender,
-    );
-    bank_forks
+    )?;
+
+    Ok(bank_forks)
 }
 
 /// Process blockstore from a known root bank
@@ -1818,7 +1822,7 @@ fn process_bank_0(
     recyclers: &VerifyRecyclers,
     block_meta_sender: Option<&BlockMetaSender>,
     entry_notification_sender: Option<&EntryNotifierSender>,
-) {
+) -> result::Result<(), BlockstoreProcessorError> {
     assert_eq!(bank0.slot(), 0);
     let mut progress = ConfirmationProgress::new(bank0.last_blockhash());
     confirm_full_slot(
@@ -1833,7 +1837,7 @@ fn process_bank_0(
         None,
         &mut ExecuteTimings::default(),
     )
-    .expect("Failed to process bank 0 from ledger. Did you forget to provide a snapshot?");
+    .map_err(|_| BlockstoreProcessorError::FailedToReplayBank0)?;
     if let Some((result, _timings)) = bank0.wait_for_completed_scheduler() {
         result.unwrap();
     }
@@ -1842,6 +1846,8 @@ fn process_bank_0(
         blockstore.insert_bank_hash(bank0.slot(), bank0.hash(), false);
     }
     send_block_meta(bank0, block_meta_sender);
+
+    Ok(())
 }
 
 // Given a bank, add its children to the pending slots queue if those children slots are
@@ -4201,7 +4207,8 @@ pub mod tests {
             &recyclers,
             None,
             None,
-        );
+        )
+        .unwrap();
         let bank0_last_blockhash = bank0.last_blockhash();
         let bank1 = bank_forks.write().unwrap().insert(Bank::new_from_parent(
             bank0.clone_without_scheduler(),