clippy: useless_conversion (anza-xyz#5060)

Author: brooksprumo

banks-client/src/lib.rs

@@ -448,7 +448,6 @@ impl BanksClient {
             .await?
             .map(|x| x.0)
             .ok_or(BanksClientError::ClientError("valid blockhash not found"))
-            .map_err(Into::into)
     }
 
     pub async fn get_latest_blockhash_with_commitment(

cli/src/checks.rs

@@ -1,11 +1,8 @@
 use {
-    crate::cli::CliError,
-    solana_commitment_config::CommitmentConfig,
-    solana_message::Message,
-    solana_native_token::lamports_to_sol,
-    solana_pubkey::Pubkey,
+    crate::cli::CliError, solana_commitment_config::CommitmentConfig, solana_message::Message,
+    solana_native_token::lamports_to_sol, solana_pubkey::Pubkey,
     solana_rpc_client::rpc_client::RpcClient,
-    solana_rpc_client_api::client_error::{Error as ClientError, Result as ClientResult},
+    solana_rpc_client_api::client_error::Result as ClientResult,
 };
 
 pub fn check_account_for_fee(
@@ -96,9 +93,7 @@ pub fn check_account_for_spend_and_fee_with_commitment(
         account_pubkey,
         required_balance,
         commitment,
-    )
-    .map_err(Into::<ClientError>::into)?
-    {
+    )? {
         if balance > 0 {
             return Err(CliError::InsufficientFundsForSpendAndFee(
                 lamports_to_sol(balance),

programs/bpf_loader/src/syscalls/mem_ops.rs

@@ -341,17 +341,15 @@ where
         src_addr,
         n_bytes,
         resize_area,
-    )
-    .map_err(EbpfError::from)?;
+    )?;
     let mut dst_chunk_iter = MemoryChunkIterator::new(
         memory_mapping,
         accounts,
         dst_access,
         dst_addr,
         n_bytes,
         resize_area,
-    )
-    .map_err(EbpfError::from)?;
+    )?;
 
     let mut src_chunk = None;
     let mut dst_chunk = None;