Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please shade Guava #20

Open
bolkedebruin opened this issue Jun 17, 2018 · 2 comments
Open

Please shade Guava #20

bolkedebruin opened this issue Jun 17, 2018 · 2 comments
Labels
good first issue Hacktoberfest hacktoberfest-accepted help wanted

Comments

@bolkedebruin
Copy link

Guava is not backward compatible and if an including project also uses Guava this results in conflicts. By shading Guava this is not an issue anymore.
@hrchu
Copy link
Member

hrchu commented Jun 19, 2018

Hi thanks for the reminder. Would you like to send a PR for it?

@hrchu hrchu reopened this Jun 19, 2018
@bolkedebruin
Copy link
Author

I'll have a look, but as you are not building an uber-jar it wasnt required for my purposes and I was able to do it in my own pom.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Hacktoberfest hacktoberfest-accepted help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hrchu @bolkedebruin