Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for go-logr #237

Closed
rmb938 opened this issue Oct 26, 2022 · 4 comments · Fixed by #356
Closed

Add support for go-logr #237

rmb938 opened this issue Oct 26, 2022 · 4 comments · Fixed by #356
Labels
enhancement New feature or request help wanted plugin PRs related to plugins

Comments

@rmb938
Copy link
Contributor

rmb938 commented Oct 26, 2022

Would be nice to have a plugin that supports https://github.com/go-logr/logr so it can be used with kgo.WithLogger

@twmb
Copy link
Owner

twmb commented Oct 28, 2022

I'd be open to have this in a plugin at /plugin/klogr perhaps. Writing logger plugins is pretty small, if you want to take a stab (otherwise, I'm not sure where this particular issue falls on my priority list 😅).

@rmb938
Copy link
Contributor Author

rmb938 commented Oct 28, 2022

Sounds good. And yea myself or one of my co-workers will contribute within the next few weeks if you don't get to it first :)

@twmb
Copy link
Owner

twmb commented Feb 15, 2023

Is #356 what you're thinking?

@twmb twmb added the plugin PRs related to plugins label Feb 22, 2023
@rmb938
Copy link
Contributor Author

rmb938 commented Feb 25, 2023

Yup that is perfect

@twmb twmb closed this as completed in #356 Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted plugin PRs related to plugins
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants