Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kgo: add CloseAllowingRebalance #187

Closed
twmb opened this issue Aug 5, 2022 · 1 comment
Closed

kgo: add CloseAllowingRebalance #187

twmb opened this issue Aug 5, 2022 · 1 comment

Comments

@twmb
Copy link
Owner

twmb commented Aug 5, 2022

Two forks of this repo added logs all over to track down why Close was hanging:

ar3s3ru/kprocessor@b5b4b3d#r76473229
bernardoVale@29aff20#commitcomment-78931790

The main issue is that BlockRebalanceOnPoll also blocks client closing, because client close leaves a group, which causes a rebalance.

The client shouldn't just unblock when closing, because the user may have some logic that is unsafe to run unless guaranteed to be serial.

At a minimum, the docs on Close need to be updated to note how the user needs to run AllowRebalance before closing. Potentially, another API can be added, CloseAllowingRebalance.

twmb referenced this issue in bernardoVale/franz-go Aug 5, 2022
@twmb twmb closed this as completed in 2b38ec5 Aug 22, 2022
@twmb
Copy link
Owner Author

twmb commented Aug 22, 2022

This has been released in v1.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant