balancing: LogLevelError if BalanceOrError returns an error

twmb · May 1, 2022 · b457742 · b457742
1 parent e8e5117
commit b457742
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/pkg/kgo/group_balancer.go b/pkg/kgo/group_balancer.go
@@ -451,13 +451,13 @@ func (g *groupConsumer) balanceGroup(proto string, members []kmsg.JoinGroupRespo
 	// more useful debugging information.
 	var into IntoSyncAssignment
 	if memberBalancerOrErr, ok := memberBalancer.(GroupMemberBalancerOrError); ok {
-		into, err = memberBalancerOrErr.BalanceOrError(topicPartitionCount)
+		if into, err = memberBalancerOrErr.BalanceOrError(topicPartitionCount); err != nil {
+			g.cl.cfg.logger.Log(LogLevelError, "balance failed", "err", err)
+			return nil, err
+		}
 	} else {
 		into = memberBalancer.Balance(topicPartitionCount)
 	}
-	if err != nil {
-		return nil, err
-	}
 
 	if p, ok := into.(*BalancePlan); ok {
 		g.cl.cfg.logger.Log(LogLevelInfo, "balanced", "plan", p.String())