kversion: fix overflow panic for SetMaxKeyVersion

twmb · Feb 20, 2021 · 8a42602 · 8a42602
1 parent 4aa4187
commit 8a42602
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/pkg/kversion/kversion.go b/pkg/kversion/kversion.go
@@ -76,7 +76,7 @@ func (vs *Versions) SetMaxKeyVersion(k, v int16) {
 	if k < 0 || v < 0 && int(k) >= len(vs.k2v)+1 {
 		return
 	}
-	needLen := int(k + 1)
+	needLen := int(k) + 1
 	for len(vs.k2v) < needLen {
 		vs.k2v = append(vs.k2v, -1)
 	}

diff --git a/pkg/kversion/kversion_test.go b/pkg/kversion/kversion_test.go
@@ -1,9 +1,22 @@
 package kversion
 
 import (
+	"math"
 	"testing"
 )
 
+func TestSetMaxKeyVersion(t *testing.T) {
+	var vs Versions
+	for i := int16(0); i < math.MaxInt16; i++ {
+		vs.SetMaxKeyVersion(i, i)
+	}
+	for i, v := range vs.k2v {
+		if int16(i) != v {
+			t.Errorf("set incorrect: at %d got %d != exp %d", i, v, i)
+		}
+	}
+}
+
 func TestVersionGuess(t *testing.T) {
 	// Cases where last can be empty.
 	{