EndTxn: avoid creating a producer ID if nothing was produced

twmb · May 7, 2021 · 6398677 · 6398677
1 parent c7c08fb
commit 6398677
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/pkg/kgo/txn.go b/pkg/kgo/txn.go
@@ -427,6 +427,12 @@ func (cl *Client) EndTransaction(ctx context.Context, commit TransactionEndTry)
 		}
 	}
 
+	// If no partition was added to a transaction, then we have nothing to commit.
+	if !anyAdded {
+		cl.cfg.logger.Log(LogLevelInfo, "no records were produced during the commit; thus no transaction was began; ending without doing anything")
+		return nil
+	}
+
 	id, epoch, err := cl.producerID()
 	if err != nil {
 		if commit {
@@ -468,12 +474,6 @@ func (cl *Client) EndTransaction(ctx context.Context, commit TransactionEndTry)
 		}
 	}
 
-	// If no partition was added to a transaction, then we have nothing to commit.
-	if !anyAdded {
-		cl.cfg.logger.Log(LogLevelInfo, "no records were produced during the commit; thus no transaction was began; ending without doing anything")
-		return nil
-	}
-
 	cl.cfg.logger.Log(LogLevelInfo, "ending transaction",
 		"transactional_id", *cl.cfg.txnID,
 		"producer_id", id,