Skip to content

Commit

Permalink
GroupTxnSession.End: document no error is worth retrying
Browse files Browse the repository at this point in the history
  • Loading branch information
twmb committed May 11, 2021
1 parent 231d0e4 commit 3a95ec8
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions pkg/kgo/txn.go
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,9 @@ func (s *GroupTransactSession) Begin() error {
// in committing offsets fails, this aborts.
//
// This returns whether the transaction committed or any error that occurred.
// No returned error is retriable. Either the transactional ID has entered a
// failed state, or the client retried so much that the retry limit was hit,
// and odds are you should not continue.
//
// Note that canceling the context will likely leave the client in an
// undesirable state, because canceling the context cancels in flight requests
Expand Down

0 comments on commit 3a95ec8

Please sign in to comment.