Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Buf instead of ChannelBuffer in storehaus-redis #310

Open
BenFradet opened this issue Jul 3, 2016 · 1 comment
Open

Expose Buf instead of ChannelBuffer in storehaus-redis #310

BenFradet opened this issue Jul 3, 2016 · 1 comment

Comments

@BenFradet
Copy link
Contributor

Since Finagle is moving away from exposing netty's ChannelBuffer in their API in favor of twitter util's Buf, I think we should too.

From the recent commits, I think the replacement should be complete by Finagle's next release.

@johnynek
Copy link
Collaborator

johnynek commented Jul 3, 2016

Yeah, I think this is a good call. (PS: lesson to be learned here, it is a good idea to hide all your dependencies on your public API in general. We didn't do that in a few places in scalding, I really regret it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants