Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default buffer size #137

Open
thinkingfish opened this issue Jan 24, 2017 · 3 comments
Open

Update default buffer size #137

thinkingfish opened this issue Jan 24, 2017 · 3 comments

Comments

@thinkingfish
Copy link
Contributor

To subtract 16 bytes (metadata overhead for malloc) from the current default size, which is exactly 16KB

@kevyang
Copy link
Contributor

kevyang commented Jul 27, 2018

Would we also want to update dbuf so that one double gives 32KB - 16 bytes, 2 doubles give 64KB - 16, etc? Or do you think it's acceptable to simply double them?

@kevyang
Copy link
Contributor

kevyang commented Jul 27, 2018

Probably the former, as it would make the best fit in a whole number of pages, correct?

@kevyang
Copy link
Contributor

kevyang commented Aug 3, 2018

maybe this is a silly question, but would it be better to use mmap to allocate buffer in this case, so we can also have the buffer page aligned?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants