Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Add EventSub webhook revocation #203

Closed
Dkamps18 opened this issue Dec 13, 2022 · 2 comments
Closed

[Feature Request] Add EventSub webhook revocation #203

Dkamps18 opened this issue Dec 13, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@Dkamps18
Copy link
Contributor

Dkamps18 commented Dec 13, 2022 •
edited
Loading

Somehow the revocation message type is missing. Would be nice if we can test the handling of those too!
https://dev.twitch.tv/docs/eventsub/handling-webhook-events#revoking-your-subscription
@Xemdo
Copy link
Contributor

Xemdo commented Dec 13, 2022

Added in #169 as --subscription-status flag on twitch event trigger.
However I'm leaving this open as an improvement request, since it should be moved to its own command, similar to twitch event verify

@Xemdo Xemdo added the enhancement New feature or request label Dec 13, 2022
@Xemdo
Copy link
Contributor

Xemdo commented Apr 1, 2023

Debated over this when implementing #217 and decided the current system works best. Given the need to send over multiple transports (webhook, websocket) it wouldn't fit well. May re-evaluate in the future.

@Xemdo Xemdo closed this as completed Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Xemdo @Dkamps18