Skip to content

Commit 4ab598e

Browse files
author
Braxton Lancial
committed
Addressing first comments
Addressing first comments by editing "stream_change" to "stream-change" as the trigger. Adding "TagIDs".
1 parent b289e53 commit 4ab598e

File tree

3 files changed

+12
-11
lines changed

3 files changed

+12
-11
lines changed

docs/event.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ Used to either create or send mock events for use with local webhooks testing.
3030
| `update-redemption` | Channel Points EventSub event for a redemption being updated. |
3131
| `raid` | Channel Raid event with a random viewer count. |
3232
| `revoke` | User authorization revoke event. Uses local Client as set in `twitch configure` or generates one randomly. |
33-
| `stream_change` | Stream Changed event. |
33+
| `stream-change` | Stream Changed event. |
3434
| `streamup` | Only usable with the `eventsub` transport, a stream online event. |
3535
| `streamdown` | Only usable with the `eventsub` transport, a stream offline event. |
3636
| `add-moderator` | Channel moderator add event. |

internal/events/types/stream_change/stream_change_event.go

+4-3
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ var transportsSupported = map[string]bool{
1717
models.TransportEventSub: true,
1818
}
1919

20-
var triggerSupported = []string{"stream_change"}
20+
var triggerSupported = []string{"stream-change"}
2121

2222
var triggerMapping = map[string]map[string]string{
2323
models.TransportWebSub: {
@@ -35,7 +35,7 @@ func (e Event) GenerateEvent(params events.MockEventParameters) (events.MockEven
3535
var err error
3636

3737
if params.StreamTitle == "" {
38-
params.StreamTitle = "Default Title!"
38+
params.StreamTitle = "Example title from the CLI!"
3939
}
4040

4141
switch params.Transport {
@@ -86,7 +86,8 @@ func (e Event) GenerateEvent(params events.MockEventParameters) (events.MockEven
8686
StreamViewerCount: 9848,
8787
StreamStartedAt: util.GetTimestamp().Format(time.RFC3339),
8888
StreamLanguage: "en",
89-
StreamThumbnailURL: "https://static-cdn.jtvnw.net/previews-ttv/live_user_lirik-{width}x{height}.jpg",
89+
StreamThumbnailURL: "https://static-cdn.jtvnw.net/previews-ttv/live_twitch_user-{width}x{height}.jpg",
90+
TagIDs: make([]string, 0),
9091
},
9192
},
9293
}

internal/events/types/stream_change/stream_change_event_test.go

+7-7
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ func TestEventSub(t *testing.T) {
2121
FromUserID: fromUser,
2222
ToUserID: toUser,
2323
Transport: models.TransportEventSub,
24-
Trigger: "stream_change",
24+
Trigger: "stream-change",
2525
}
2626

2727
r, err := Event{}.GenerateEvent(params)
@@ -49,19 +49,19 @@ func TestEventSub(t *testing.T) {
4949
a.Nil(err)
5050

5151
a.Equal(toUser, body.Event.BroadcasterUserID, "Expected Stream Channel %v, got %v", toUser, body.Event.BroadcasterUserID)
52-
a.Equal("Default Title!", body.Event.StreamTitle, "Expected new stream title, got %v", body.Event.StreamTitle)
52+
a.Equal("Example title from the CLI!", body.Event.StreamTitle, "Expected new stream title, got %v", body.Event.StreamTitle)
5353
}
5454

5555
func TestWebSubStreamChange(t *testing.T) {
5656
a := util.SetupTestEnv(t)
5757

58-
newStreamTitle := "Awesome new title!"
58+
newStreamTitle := "Awesome new title from the CLI!"
5959

6060
params := *&events.MockEventParameters{
6161
FromUserID: fromUser,
6262
ToUserID: toUser,
6363
Transport: models.TransportWebSub,
64-
Trigger: "stream_change",
64+
Trigger: "stream-change",
6565
StreamTitle: newStreamTitle,
6666
}
6767

@@ -83,7 +83,7 @@ func TestFakeTransport(t *testing.T) {
8383
FromUserID: fromUser,
8484
ToUserID: toUser,
8585
Transport: "fake_transport",
86-
Trigger: "stream_change",
86+
Trigger: "stream-change",
8787
}
8888

8989
r, err := Event{}.GenerateEvent(params)
@@ -93,7 +93,7 @@ func TestFakeTransport(t *testing.T) {
9393
func TestValidTrigger(t *testing.T) {
9494
a := util.SetupTestEnv(t)
9595

96-
r := Event{}.ValidTrigger("stream_change")
96+
r := Event{}.ValidTrigger("stream-change")
9797
a.Equal(true, r)
9898

9999
r = Event{}.ValidTrigger("not_trigger_keyword")
@@ -112,6 +112,6 @@ func TestValidTransport(t *testing.T) {
112112
func TestGetTopic(t *testing.T) {
113113
a := util.SetupTestEnv(t)
114114

115-
r := Event{}.GetTopic(models.TransportEventSub, "stream_change")
115+
r := Event{}.GetTopic(models.TransportEventSub, "stream-change")
116116
a.NotNil(r)
117117
}

0 commit comments

Comments
 (0)