Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

public APIs should not swallow arbitrary invalid keyword arguments #287

Closed
3 tasks done
glyph opened this issue Aug 4, 2020 · 2 comments · Fixed by #319
Closed
3 tasks done

public APIs should not swallow arbitrary invalid keyword arguments #287

glyph opened this issue Aug 4, 2020 · 2 comments · Fixed by #319
Assignees
@twm
Labels
bug
Milestone
treq 21.5.0

Comments

@glyph
Copy link
Member

glyph commented Aug 4, 2020 •
edited by twm
Loading

This needs to be done in three steps:

  • emit a deprecation warning when emitting unused keyword arguments
  • do a release with the deprecation warning
  • remove the **kwargs entirely

#251 was both the initial report of this as well as a proposed implementation, but its author lost interest.
@glyph glyph mentioned this issue Aug 4, 2020
Closed
@twm twm self-assigned this Sep 29, 2020
@twm twm mentioned this issue Sep 30, 2020
Merged
@twm twm added the bug label Sep 30, 2020
@twm
Copy link
Contributor

twm commented Oct 3, 2020

#297 adds deprecation warnings. It needs review.

@twm twm added this to the Treq NEXT milestone Jan 16, 2021
@twm twm mentioned this issue Jan 16, 2021
Merged
@twm
Copy link
Contributor

twm commented Jan 25, 2021

#319 removes **kwargs entirely.

@twm twm closed this as completed in #319 Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@twm twm

Labels
bug
Projects
None yet
Milestone
treq 21.5.0
Development

Successfully merging a pull request may close this issue.

Reject invalid keyword arguments with TypeError twm/treq
2 participants
@twm @glyph