Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression introduced by #610 #651

Merged
merged 5 commits into from
Aug 5, 2024

Conversation

znichollscr
Copy link
Contributor

@znichollscr znichollscr commented Aug 5, 2024

Description

Fixes #648

Checklist

  • Make sure changes are covered by existing or new tests.
  • For at least one Python version, make sure test pass on your local environment.
  • Create a file in src/towncrier/newsfragments/. Briefly describe your
    changes, with information useful to end users. Your change will be included in the public release notes.
  • Make sure all GitHub Actions checks are green (they are automatically checking all of the above).
  • Ensure docs/tutorial.rst is still up-to-date.
    * [ ] If you add new CLI arguments (or change the meaning of existing ones), make sure docs/cli.rst reflects those changes.
  • If you add new configuration options (or change the meaning of existing ones), make sure docs/configuration.rst reflects those changes.

@znichollscr znichollscr requested a review from a team as a code owner August 5, 2024 13:13
Copy link
Member

@adiroiban adiroiban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Changes looks good.

I am looking at the Markdown tutorial documentation at https://towncrier.readthedocs.io/en/latest/markdown.html

and I can see that it has this config

title_format = "## [{version}](https://github.com/twisted/my-project/tree/{version}) - {project_date}"

so it looks like #610 is a bug.


Thanks again.

@adiroiban adiroiban merged commit eed6d16 into twisted:trunk Aug 5, 2024
16 checks passed
@speedenator
Copy link

fixed while I slept. Love it! Thanks @znichollscr and @adiroiban !

@znichollscr znichollscr deleted the 648-fix-md-formatting branch August 6, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markdown lines should not have '# ' prepended
3 participants