Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the explicit setting of a pygments theme #625

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

pradyunsg
Copy link
Contributor

@pradyunsg pradyunsg commented Jul 21, 2024

This allows the underlying theme being used to provide the pygments theme instead which looks better (subjectively).

Description

Checklist

  • Make sure changes are covered by existing or new tests.
  • For at least one Python version, make sure local test run is green.
  • Create a file in src/towncrier/newsfragments/. Describe your
    change and include important information. Your change will be included in the public release notes.
  • Make sure all GitHub Actions checks are green (they are automatically checking all of the above).
  • Ensure docs/tutorial.rst is still up-to-date.
  • If you add new CLI arguments (or change the meaning of existing ones), make sure docs/cli.rst reflects those changes.
  • If you add new configuration options (or change the meaning of existing ones), make sure docs/configuration.rst reflects those changes.

@pradyunsg pradyunsg requested a review from a team as a code owner July 21, 2024 18:07
@pradyunsg
Copy link
Contributor Author

  • Create a file in src/towncrier/newsfragments/.

I don't think this is a news worthy change, but let me know if you want one.

docs/conf.py Outdated Show resolved Hide resolved
@adiroiban
Copy link
Member

adiroiban commented Jul 22, 2024

Thanks for the update.

I triggerd the build so can check the new version on Read the docs.

I don't think this is a news worthy change, but let me know if you want one.

If it's not news worthy, then we need a newsfragment/625.misc file.

This confirm that the release notes information was considred and it was decided not to add any explicit text.

As opposed of not having a newsfragment file and thinking that the author of the PR has forgot about the release notes :)

This allows the underlying theme being used to provide the pygments
theme instead which looks better (subjectively).
@adiroiban
Copy link
Member

This is subjective ... but I think that we can merge it.

Thanks :)

@adiroiban adiroiban merged commit a5a51b1 into twisted:trunk Jul 23, 2024
16 checks passed
@pradyunsg pradyunsg deleted the sphinx-pygments-theme branch July 23, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants