Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

towncrier check should not fail on revert commits that *remove* a news fragment #598

Open
glyph opened this issue May 7, 2024 · 1 comment

Comments

@glyph
Copy link
Member

glyph commented May 7, 2024

If you're reverting a PR to un-do a change that removes the newsfragment before a release so it isn't in the changelog, the PR should succeed its towncrier newsfragment check

@adiroiban
Copy link
Member

Thanks for the report


Just some extra info

There is also the release PR that removes the news fragments.

For the release PR the check is skipped based on the fact that the commit changes the NEWS.rst file.


In theory, we can merge the skip check for both release and revert PRs.

I would prefer to have separate checks.

The idea is that for a release PR you want to make sure there are no release fragment files left on the branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants