Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Also render title in markdown template without name #587

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

infinisil
Copy link
Contributor

@infinisil infinisil commented Apr 15, 2024

Description

Previously, if there was no project name defined, the default markdown template wouldn't render the title properly due to a missing #.

Checklist

  • Make sure changes are covered by existing or new tests.
  • For at least one Python version, make sure local test run is green.
  • Create a file in src/towncrier/newsfragments/. Describe your
    change and include important information. Your change will be included in the public release notes.
  • Make sure all GitHub Actions checks are green (they are automatically checking all of the above).

@infinisil infinisil requested a review from a team as a code owner April 15, 2024 16:53
Copy link
Member

@adiroiban adiroiban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for the changes.

They look good.

I left a few minor comments.

I hope we can have those improvemnets before the merge.

Thanks again!

src/towncrier/test/test_build.py Show resolved Hide resolved
src/towncrier/test/test_build.py Outdated Show resolved Hide resolved
src/towncrier/newsfragments/587.bugfix Outdated Show resolved Hide resolved
@infinisil infinisil force-pushed the fix-markdown-template-no-name branch from 0e48c1d to be83bf2 Compare April 18, 2024 13:50
@infinisil
Copy link
Contributor Author

Great suggestions, thanks! Applied them :D

@infinisil infinisil force-pushed the fix-markdown-template-no-name branch from 1294080 to d34caa9 Compare April 18, 2024 14:00
@adiroiban adiroiban enabled auto-merge (squash) April 19, 2024 01:58
@adiroiban
Copy link
Member

Thanks for your help. I have enabled auto-merge. I hope this will land soon.

@adiroiban adiroiban merged commit 914b446 into twisted:trunk Apr 19, 2024
15 checks passed
@infinisil infinisil deleted the fix-markdown-template-no-name branch April 19, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants