Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add performance tests based on cpython build runtime #584

Closed
tristanlatr opened this issue May 20, 2022 · 2 comments
Closed

Add performance tests based on cpython build runtime #584

tristanlatr opened this issue May 20, 2022 · 2 comments

Comments

@tristanlatr
Copy link
Contributor

Since #576, the system test of the standard library is now taking 47mn instead of about 35.

It should not have influenced the efficiency at this point. So I’ll consider reverting this PR.

@tristanlatr
Copy link
Contributor Author

Ok, I've checked the action runs history and it looks like the runtime is not very stable...

It takes from 35 minutes to 1 hour. I don't know exactly what the best way forward is, I know a Github job step can run up to 6 hours. So we might want to run the cpython API docs 3 times, calculate the mean, and report if the mean is more than one hour.

Also let's note that we are not checking out a specific version of the cpython, so it's not the best for consistency.

by default 2022-05-19 at 11 39 19 PM

The extension system has probably nothing to do with this.

@tristanlatr tristanlatr changed the title Performance issue with the new extension system Add performance tests based on cpython build runtime May 20, 2022
@tristanlatr
Copy link
Contributor Author

The primer includes a time based comparison, so I’ll close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant