Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle childConnectionLost #37

Closed
wants to merge 1 commit into from
Closed

handle childConnectionLost #37

wants to merge 1 commit into from

Conversation

graingert
Copy link
Member

fixed #36

glyph
glyph requested changes Mar 30, 2021
View reviewed changes
Copy link
Member

@glyph glyph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test case for this?

@glyph
Copy link
Member

glyph commented May 25, 2021

@graingert ping?

@graingert
Copy link
Member Author

@glyph sorry I don't have time to fix this anymore :(

@glyph
Copy link
Member

glyph commented May 16, 2022

I think this isn't quite correct either, since there's a "stopping" state that isn't quite reflected here. There's definitely still a bug so I'm leaving the issue open but someone else will need to tackle this at some point.

@glyph glyph closed this May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glyph glyph glyph requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ampoule doesn't handle childConnectionLost
2 participants
@graingert @glyph