feat: include API response headers in 'Last Response' (#526)

The default HTTP client stores 'Last Request' and 'Last Response' information for access to more data about the raw API request/response. The response object did not contain the headers until now.

Author: childish-sambino

src/Twilio/Http/Net35/WebRequestClient.cs

@@ -37,7 +37,7 @@ public override Response MakeRequest(Request request)
             {
                 IHttpWebResponseWrapper response = httpRequest.GetResponse();
                 string content = GetResponseContent(response);
-                this.LastResponse = new Response(response.StatusCode, content);
+                this.LastResponse = new Response(response.StatusCode, content, response.Headers);
             }
             catch (WebExceptionWrapper e)
             {
@@ -48,7 +48,7 @@ public override Response MakeRequest(Request request)
                 }
                 // Non 2XX status code
                 IHttpWebResponseWrapper errorResponse = e.Response;
-                this.LastResponse = new Response(errorResponse.StatusCode, GetResponseContent(errorResponse));
+                this.LastResponse = new Response(errorResponse.StatusCode, GetResponseContent(errorResponse), errorResponse.Headers);
             }
             return this.LastResponse;
         }

src/Twilio/Http/Net35/WebRequestWrappers.cs

@@ -35,6 +35,7 @@ public interface IHttpWebResponseWrapper
     {
         HttpStatusCode StatusCode { get; set; }
         Stream GetResponseStream();
+        WebHeaderCollection Headers { get; }
     }
 
     public class HttpWebRequestWrapper : IHttpWebRequestWrapper
@@ -125,6 +126,11 @@ public Stream GetResponseStream()
         {
             return this._httpWebResponse.GetResponseStream();
         }
+
+        public WebHeaderCollection Headers
+        {
+            get { return this._httpWebResponse.Headers; }
+        }
     }
 
     public class WebExceptionWrapper : Exception

src/Twilio/Http/Response.cs

@@ -1,5 +1,11 @@
 using System.Net;
 
+#if NET35
+using Headers = System.Net.WebHeaderCollection;
+#else
+using Headers = System.Net.Http.Headers.HttpResponseHeaders;
+#endif
+
 namespace Twilio.Http
 {
     /// <summary>
@@ -18,14 +24,21 @@ public class Response
         public string Content { get; }
 
         /// <summary>
-        /// Create a new Response 
+        /// Headers
+        /// </summary>
+        public Headers Headers { get; }
+
+        /// <summary>
+        /// Create a new Response
         /// </summary>
         /// <param name="statusCode">HTTP status code</param>
         /// <param name="content">Content string</param>
-        public Response (HttpStatusCode statusCode, string content)
+        /// <param name="headers">Headers</param>
+        public Response(HttpStatusCode statusCode, string content, Headers headers = null)
         {
             StatusCode = statusCode;
             Content = content;
+            Headers = headers;
         }
     }
 }

src/Twilio/Http/SystemNetHttpClient.cs

@@ -13,11 +13,11 @@ namespace Twilio.Http
     /// </summary>
     public class SystemNetHttpClient : HttpClient
     {
-        #if NET451
+#if NET451
         private string PlatVersion = " (.NET Framework 4.5.1+)";
-        #else
+#else
         private string PlatVersion = $" ({RuntimeInformation.FrameworkDescription})";
-        #endif
+#endif
 
         private readonly System.Net.Http.HttpClient _httpClient;
 
@@ -73,7 +73,7 @@ public override async Task<Response> MakeRequestAsync(Request request)
             // Create and return a new Response. Keep a reference to the last
             // response for debugging, but don't return it as it may be shared
             // among threads.
-            var response = new Response(httpResponse.StatusCode, await reader.ReadToEndAsync().ConfigureAwait(false));
+            var response = new Response(httpResponse.StatusCode, await reader.ReadToEndAsync().ConfigureAwait(false), httpResponse.Headers);
             this.LastResponse = response;
             return response;
         }