Allow redirects through to user

[bbenne10]

For some reason flask.redirect returns a response that is derived from werkzeug.wrappers.Response, rather than flask.Response. Testing with some dummy code proves this problem to be a bit inconsistent:

class X(object):
    def __init__(self):
        pass

class Y(X):
    def __init__(self):
        pass

z = Y()
isinstance(z, X)  #  -> True

This conflicts with what I see with Flask / Flask-Restful:

from flask import Response

#...blahblahblah basic setup
x = redirect(url_for('render_root'))
isinstance(x, Response)  #  -> False

The code on this branch fixes this, but there may be a better way to fix this problem. I'd be open to hearing and possibly implementing any other ideas. Do you guys have any other thoughts?

[bbenne10]

Okay - upon further investigation, this issue makes more sense and has a slightly different solution than I initially committed. Because flask.Response is derived from werkzeug.wrappers.Response, we should check werkzeug's Response via isinstance, rather than Flask's, as werkzeug's will not match an isinstance check (though they serve the same purpose for us)

Furthermore, my earlier code tests apples against oranges. I was testing two very distinct scenarios. Please ignore it, but I'll leave it up for posterity's sake.

[lanceingle]

+1 I needed this the other day.

Returning a Redirect object in a Restful.Response inherited class will result in "Response 302 not JSON Serializable". This pull-request fixes that.

Here is a example of the problem

from flask import Flask, redirect
from flask.ext import restful

app = Flask(__name__)
api = restful.Api(app)


class HelloWorld(restful.Resource):
    def get(self):
        return redirect('/')

api.add_resource(HelloWorld, '/api/')


@app.route('/')
def index():
    return "Hello World"

if __name__ == "__main__":
    app.debug = True
    app.run()

// lance

[bbenne10]

Does anyone have any thoughts on this?

[feigner]

+1 I need this in my life. Any idea on PR status? Seems straightforward enough...

[skimbrel]

Looks reasonable to me. I'll use the provided example problem code to write up a quick test for this behavior. Thanks!

[bbenne10]

I'm deleting my branch since this is merged. Glad to see it pulled in. Thanks, @skimbrel!

[feigner]

Heck yes! Thanks @bbenne10, @skimbrel!