Skip to content

feat(model): add Member::flags #2086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
7596ff merged 9 commits into from
Jan 28, 2023
Merged

feat(model): add Member::flags #2086

7596ff merged 9 commits into from
Jan 28, 2023

Conversation

@suneettipirneni
Copy link
Member

@suneettipirneni suneettipirneni commented Jan 23, 2023

Implements flags for guild members as per the discord documentation:

@github-actions github-actions bot added c-cache Affects the cache crate c-model Affects the model crate t-feature Addition of a new feature labels Jan 23, 2023
spring4175
spring4175 reviewed Jan 24, 2023
View reviewed changes
Copy link
Contributor

@spring4175 spring4175 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I have a comment about a missing getter, a couple nits with diff suggestions, and a couple documentation requests, but otherwise this looks great!

@spring4175 spring4175 added the d-api Change related to Discord's API. label Jan 24, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2023 •
edited
Loading

Codecov Report

Merging #2086 (3b6746f) into main (3b6746f) will not change coverage.
The diff coverage is n/a.

❗ Current head 3b6746f differs from pull request most recent head 61ff0c0. Consider uploading reports for the commit 61ff0c0 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #2086   +/-   ##
=======================================
  Coverage   36.30%   36.30%           
=======================================
  Files         402      402           
  Lines       16140    16140           
=======================================
  Hits         5860     5860           
  Misses      10280    10280

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@spring4175
Copy link
Contributor

spring4175 commented Jan 27, 2023

Failing Clippy lints are new in Rust 1.67. PR #2091 resolves them

@7596ff 7596ff merged commit eb671f1 into twilight-rs:main Jan 28, 2023
@suneettipirneni suneettipirneni deleted the feat/member/flags branch January 28, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@7596ff 7596ff 7596ff approved these changes

@spring4175 spring4175 spring4175 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c-cache Affects the cache crate c-model Affects the model crate d-api Change related to Discord's API. t-feature Addition of a new feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@suneettipirneni @codecov-commenter @spring4175 @7596ff